Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Commit

Permalink
rework for using selenium + firefox
Browse files Browse the repository at this point in the history
chromedriver has a bug that causes it to hang and then everything fails:

  SeleniumHQ/docker-selenium#87

detect if phantomjs is installed and use it, since that's less painful
for local dev workflows.

also remove the js Dockerfile; just use 'node' since the JS tests are
pretty straightforward
  • Loading branch information
vito committed Jan 16, 2016
1 parent 0e030ac commit 814b900
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 32 deletions.
30 changes: 0 additions & 30 deletions Dockerfile

This file was deleted.

8 changes: 6 additions & 2 deletions assets/javascript/concourse/concourse.pauseUnpause.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ concourse.PauseUnpause.prototype.pause = function (pause) {
}).done(function (resp, jqxhr) {
_this.pauseBtn.enable();
_this.pauseCallback();
}).error(_this.requestError.bind(_this));
}).error(function (resp) {
_this.requestError(resp);
});
};


Expand All @@ -43,7 +45,9 @@ concourse.PauseUnpause.prototype.unpause = function (event) {
}).done(function (resp) {
_this.pauseBtn.disable();
_this.unpauseCallback();
}).error(_this.requestError.bind(_this));
}).error(function (resp) {
_this.requestError(resp);
});
};

concourse.PauseUnpause.prototype.requestError = function (resp) {
Expand Down

0 comments on commit 814b900

Please sign in to comment.