Adding a module that retrieves passwords from Amazon's Parameter Store #185
Conversation
modules/awsparam.py
Outdated
| @@ -0,0 +1,85 @@ | |||
| #! /usr/bin/env python | |||
There was a problem hiding this comment.
No need for the shebang. Please replace it with
# -*- coding: utf-8 -*-
modules/awsparam.py
Outdated
| @@ -0,0 +1,85 @@ | |||
| #! /usr/bin/env python | |||
| """Salt module that retrieves a key stored in Amazon's Parameter store. | |||
There was a problem hiding this comment.
Please standardize multi-line comments to use triple single quotes instead of triple double quotes.
modules/awsparam.py
Outdated
| return "eu-west-1" | ||
|
|
||
| def get_parameter (name): | ||
| '''Get a parametewr by name.''' |
There was a problem hiding this comment.
We prefer the triple single quotes be on their own lines like this:
'''
Get a parameter by name.
'''
Also, please fix parameter misspelling.
modules/awsparam.py
Outdated
| return "eu-west-1" | ||
|
|
||
| def get_parameter (name): | ||
| '''Get a parametewr by name.''' |
There was a problem hiding this comment.
Per pep8, please use 4 spaces for each indentation level.
ram-dog
changed the title
|
Ok, I've made the requested changes. Please let me know if there is anything else you would like to see. Thanks! |
|
@UtahDave Do the changes look satisfactory? |
|
Thanks for the updates! |
|
SSM was added for the Neon release here: saltstack/salt#50215 If there is any missing functionality, please feel free to collaborate on it upstream. |
Salt module that retrieves a key stored in Amazon's Parameter store.
https://docs.aws.amazon.com/systems-manager/latest/userguide/systems-manager-paramstore.html/