This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
Detect imported extvars and TLAs via sentinel import path #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Jsonnet consults an Importer for a path nominated by an external variable or top-level argument file-based command-line flag, the "importedFrom" parameter passed to the Importer.Import method is not a valid URL, but is instead a sentinel placeholder value (namely, an empty string). Detect these sentinel values and use the current working directory as the base URL instead when resolving relative import paths.
seh
force-pushed
the
use-new-importer-iface-contract
branch
from
9b56c67 to
59cec69
Compare
|
See google/go-jsonnet#447. With that, we can proceed here. @mkmik, take note. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Jsonnet consults an Importer for a path nominated by an external variable or top-level argument file-based command-line flag, the "importedFrom" parameter passed to the
Importer.Importmethod is not a valid URL, but is instead a sentinel placeholder value—namely, an empty string. Detect these sentinel values and use the current working directory as the base URL instead when resolving relative import paths.NB: This patch is speculative for now, based on a change to the Jsonnet
Importer.Importmethod's contract proposed by @sbarzowski (#266 (comment)). See google/go-jsonnet#329 for a request for establishing this contract.This change is