Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

[backports/1.3/manifests] backported changes to manifests #550

Merged
merged 2 commits into from
May 20, 2019
Merged

[backports/1.3/manifests] backported changes to manifests #550

merged 2 commits into from
May 20, 2019

Conversation

sameersbn
Copy link
Contributor

  • manifests: reload grafana pods on ConfigMap updates
  • manifests: define grafana plugins array

manifests: reload grafana pods on ConfigMap updates
b815c2f 
To apply any configuration updates to grafana the Pods need to be restarted.
To achieve this we changed grafana `ConfigMaps` to  `HashedConfigMap` which will
force the Pod update whenever the contents of the reference `ConfigMap` changes.

(cherry picked from commit c32f630)
@sameersbn sameersbn requested a review from anguslees May 20, 2019 06:34
manifests: define grafana plugins array
1a53765 
the `plugins` array would allow users to easily install plugins to grafana using jsonnet overrides,
f.e. the following jsonnet overlay for grafana will install the listed plugins when applied

{
  plugins:: [
    "grafana-piechart-panel",
    "grafana-worldmap-panel",
  ],
}

(cherry picked from commit f093e40)
@sameersbn sameersbn force-pushed the backports-1.3-manifests-20190520 branch from 3900d32 to 1a53765 Compare May 20, 2019 06:56
anguslees
anguslees approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@anguslees anguslees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Merge #550
a3aeab9 
550: [backports/1.3/manifests] backported changes to manifests r=anguslees a=sameersbn

- manifests: reload grafana pods on ConfigMap updates
- manifests: define grafana plugins array

Co-authored-by: Sameer Naik <sameer@bitnami.com>
@bors
Copy link
Contributor

bors bot commented May 20, 2019

Build succeeded

@bors bors bot merged commit 1a53765 into vmware-archive:release-1.3 May 20, 2019
@sameersbn sameersbn deleted the backports-1.3-manifests-20190520 branch May 20, 2019 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anguslees anguslees anguslees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sameersbn @anguslees