This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
[backports/ci/1.2] backport ci updates #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 10, 2019 07:55
anguslees
approved these changes
May 10, 2019
| @@ -16,6 +16,64 @@ def parentZoneResourceGroup = 'jenkins-bkpr-rg' | |||
| // Force using our pod | |||
| def label = env.BUILD_TAG.replaceAll(/[^a-zA-Z0-9-]/, '-').toLowerCase() | |||
|
|
|||
| def scmCheckout() { | |||
| def repo_url = env.GITHUB_REPO_GIT_URL | |||
| def sha = env.GITHUB_PR_HEAD_SHA ? env.GITHUB_PR_HEAD_SHA : env.GITHUB_BRANCH_HEAD_SHA | |||
There was a problem hiding this comment.
Fwiw, groovy has an "elvis operator", for exactly this "fallback default" situation (should be equivalent to your long version):
Suggested change
| def sha = env.GITHUB_PR_HEAD_SHA ? env.GITHUB_PR_HEAD_SHA : env.GITHUB_BRANCH_HEAD_SHA | |
| def sha = env.GITHUB_PR_HEAD_SHA ?: env.GITHUB_BRANCH_HEAD_SHA |
There was a problem hiding this comment.
nice! will update
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.