-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Disaggregated prefilling support X prefill + Y decode #9537
base: main
Are you sure you want to change the base?
Conversation
…vllm into kuntai-disagg-refactor
Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Hi,
I am implementing the feature of Disaggregated prefilling support X prefill + Y decode based on this #8498. Currently, the one prefill + one decode form in this PR has been implemented. I think that to implement the X prefill + Y decode form, a kv database must be introduced. Fortunately, I have already integrated valkey (redis over rdma) #8724. In the next step of my work, I will introduce this kv database and then conduct tests. Now I want to introduce my design solution, and everyone can provide some suggestions.
New components:
Data flow:
Benchmark
python3 benchmark_serving.py --backend vllm --dataset-name random --model /root/lcq/model/Llama-2-7b-hf --tokenizer /root/lcq/model/Llama-2-7b-hf --random-input-len 128 --random-output-len 8 --request-rate 4 --num-prompts 64
pr([Core] Implementing disaggregated prefilling, and caching KV cache in CPU/disk/database. #8498):
this pr
The performance is basically the same.