-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] hide best_of from engine #9261
[misc] hide best_of from engine #9261
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this impact the best_of
performance?
it does not affect the performance. purely just hide |
Co-authored-by: Brendan Wong <bjwpokemon@gmail.com> Signed-off-by: Alvant <alvasian@yandex.ru>
Co-authored-by: Brendan Wong <bjwpokemon@gmail.com> Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
Co-authored-by: Brendan Wong <bjwpokemon@gmail.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Co-authored-by: Brendan Wong <bjwpokemon@gmail.com>
Co-authored-by: Brendan Wong <bjwpokemon@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
submit on behalf of @LunrEclipse