Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Hardware] Fix model input for decode #9115

Closed
wants to merge 1 commit into from

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented Oct 7, 2024

CPU backend is fixed by #9044 , but I think we can make below changes so that no more fix needed for other backends. Verified on XPU backend.

@LiuXiaoxuanPKU

Copy link

github-actions bot commented Oct 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

I prefer fixing the issue on each model runner as IMO passing an empty list instead of None is semantically wrong.

@DarkLight1337
Copy link
Member

Not sure what others think?

@jikunshang
Copy link
Contributor

I think this will break multi step features(which num_seqs should be num_steps).
I have a fix here #9145

@njhill
Copy link
Member

njhill commented Oct 8, 2024

@DarkLight1337 I agree, it’s potentially more misleading otherwise.

@yma11
Copy link
Contributor Author

yma11 commented Oct 8, 2024

Thanks for everyone's comments. Sorry for not familiar with other path calls about this variable. Let me close it.

@yma11 yma11 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants