-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] New interface and automatic detection for PP support #9000
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
7b649de
to
30e454a
Compare
11e95ff
to
37cc51b
Compare
ideally we should support pp for all models. I'm waiting for @andoorve to support this. for multi-modality support, we can use this approach. |
Closing as #7168 will include these changes. |
In this PR, I have updated the model registry to import model modules in a separate process to check whether they support PP. This avoids initializing CUDA for the main program. I have also applied this to the check for multimodal models.
With this improvement, I won't have to add almost every model to the hardcoded list for #7168.
While working on this, I have also moved the iteration over
architectures
fromModelConfig
intoModelRegistry
. This supersedes #8924.