Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][VLM] Add precise multi-modal placeholder tracking #8346
base: main
Are you sure you want to change the base?
[Core][VLM] Add precise multi-modal placeholder tracking #8346
Changes from 23 commits
d5e298f
aa756bf
46ee2d5
6c7830e
bf7d874
33e3023
8ebd665
5da9450
c5d0d7f
7a6cbe9
1a617f2
509cbac
cb2dc49
b60ec8c
defb59c
5a48342
a8025f9
c10dff9
862c46c
f14ab68
938b857
6611261
d0d1ea2
d0bc54d
f0b7a3f
5171297
fc0c190
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to give
multi_modal_placeholder_maps
a default value, so that in non-multi-modal scenariosmulti_modal_placeholder_maps
need not be specifiedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I could -- unfortunately because this is the base type for the other
AttentionMetadata
types, doing so would require that all fields in all derived types also have default values.