Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove engine-use-ray #8041

Closed
wants to merge 2 commits into from

Conversation

simon-mo
Copy link
Collaborator

Finally removing this. We should start looking at worker-use-ray too.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo simon-mo requested a review from youkaichao August 30, 2024 18:52
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 30, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad that this can be removed, we don't see any users complaining at #7045 .

please check the failed tests and see if they are relevant.

@njhill
Copy link
Member

njhill commented Sep 3, 2024

Thanks @simon-mo! It would be great to get this merged asap since it simplifies other changes being made (and the code in general).

I think at some point at least, some of the tests "relied" on this setting to avoid the issues with re-initializing a vllm in the same process, especially in multi-worker cases. There have been some improvements to that but it might be that something else is needed instead to get around this, like splitting into separate tests / pytest invocations for example.

@simon-mo
Copy link
Collaborator Author

simon-mo commented Sep 3, 2024

superseded by #8126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants