Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Disable retries and use context manager for openai client #7565

Merged
merged 4 commits into from
Aug 27, 2024
Merged

[Tests] Disable retries and use context manager for openai client #7565

merged 4 commits into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. [Tests] Disable retries and use context manager for openai client 

    The openai python client by default retries failed requests up to two times. In our tests I think we should disable this to avoid hiding issues.

Doing this actually caused some other failures, which seem to be related to how a single client fixture is shared between multiple async tests.

The openai docs suggest it should be used via a context manager so I have updated the various usages to do so and have reduced the scope of associated client fixtures.
    @njhill
    njhill committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0e867fc View commit details
    Browse the repository at this point in the history

  2. more haste less speed

    @njhill
    njhill committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8d21009 View commit details
    Browse the repository at this point in the history

  3. Update more-recently-added tests

    @njhill
    njhill committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dc839c7 View commit details
    Browse the repository at this point in the history

  4. One more

    @njhill
    njhill committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bdaf563 View commit details
    Browse the repository at this point in the history