Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrontEnd] Keep RPC server tcp protocol #7365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

esmeetu
Copy link
Collaborator

@esmeetu esmeetu commented Aug 9, 2024

Motivation: Keep RPC tcp mode is useful when we want to deploy api server and vllm engine server on different machine.

Related PR: #7222

image

Furthermore, i want to decouple api server with vllm engine server in the future, where we can update one of them without shutdown another server.

Use case:

# start rpc server on Node1
vllm serve model_arg --engine-use-rpc

# start api server on Node2
vllm start --adress tcp://Node1:5570

vLLM RPC System(Experimental):

image


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Copy link

github-actions bot commented Aug 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member

where we can update one of them without shutdown another server

looks like a corner case. what's the motivation for this? when you shutdown the engine server, the api server is not usable.

@robertgshaw2-neuralmagic
Copy link
Collaborator

As part of this, we need to make sure that port selection is robust

@njhill
Copy link
Member

njhill commented Aug 10, 2024

I think the main thing is that we make it clear the interface/protocol between the two procs is not yet stable, will likely change over the next few versions as we refine things.

@esmeetu
Copy link
Collaborator Author

esmeetu commented Aug 10, 2024

where we can update one of them without shutdown another server

looks like a corner case. what's the motivation for this? when you shutdown the engine server, the api server is not usable.

Yes, but when i reboot api server(light), i won't touch engine server (heavy, might multi-node serving the large model). But ipc mode can also achieve this if we know the ipc path. And rpc mode just for distributed server environment.

@esmeetu
Copy link
Collaborator Author

esmeetu commented Aug 10, 2024

I think the main thing is that we make it clear the interface/protocol between the two procs is not yet stable, will likely change over the next few versions as we refine things.

Yes, and I also add some ideas in the description.

@esmeetu
Copy link
Collaborator Author

esmeetu commented Aug 10, 2024

As part of this, we need to make sure that port selection is robust

ok, will look into this. But currently we can use VLLM_RPC_PORT to control.

@youkaichao
Copy link
Member

when i reboot api server(light), i won't touch engine server (heavy, might multi-node serving the large model)

can you elaborate on this? what's the usecase of rebooting just the api server?

@esmeetu
Copy link
Collaborator Author

esmeetu commented Aug 10, 2024

when i reboot api server(light), i won't touch engine server (heavy, might multi-node serving the large model)

can you elaborate on this? what's the usecase of rebooting just the api server?

Such as adding some features for api server or api server crash for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants