Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix frontend multiprocessing hang #7217

Merged
merged 10 commits into from
Aug 7, 2024
Merged

[BugFix] Fix frontend multiprocessing hang #7217

merged 10 commits into from
Aug 7, 2024

Commits on Aug 6, 2024

  1. Fix frontend multiprocessing hang 

    If the server dies, the frontend keeps waiting for it to come up for
ever

Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c7ea323 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'vllm-project:main' into fix_multiprocess_hang

    @maxdebayser
    maxdebayser authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a296788 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. address review comments 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c120770 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix_multiprocess_hang' of github.com:maxdebayser/vllm i… 

    …nto fix_multiprocess_hang
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9aea142 View commit details
    Browse the repository at this point in the history

  3. improve exception message 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    33e503b View commit details
    Browse the repository at this point in the history

  4. add unit to constant name 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fbefbe0 View commit details
    Browse the repository at this point in the history

  5. Expand comment about zmq socket options 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    72c4fb7 View commit details
    Browse the repository at this point in the history

  6. add unit test 

    Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
    @maxdebayser
    maxdebayser committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6283c66 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'vllm-project:main' into fix_multiprocess_hang

    @maxdebayser
    maxdebayser authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    093c7a4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix_multiprocess_hang

    @robertgshaw2-neuralmagic
    robertgshaw2-neuralmagic authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a2f2639 View commit details
    Browse the repository at this point in the history