Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] set timeout for test_oot_registration.py #7082

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

youkaichao
Copy link
Member

observed multiple errors in the main branch ci, e.g. https://buildkite.com/vllm/ci-aws/builds/6093#019113ce-d6dd-4cb5-8dda-d5d66dd344e9 and https://buildkite.com/vllm/ci-aws/builds/6084#019111f1-a753-42f7-9b32-2fb916f22866 .

They error with:

AssertionError: Error in memory profiling. This happens when the GPU memory was not properly cleaned up before initializing the vLLM instance.

It turns out to be flaky. One retry works https://buildkite.com/vllm/ci-aws/builds/6084#019113eb-bc79-48e8-8849-57f729e30475 , while another does not.

Still investigating, but we need to add timeout to the test, to avoid hanging for one hour.

Copy link

github-actions bot commented Aug 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao merged commit 8069495 into vllm-project:main Aug 2, 2024
16 of 19 checks passed
@youkaichao youkaichao deleted the fix_timeout branch August 2, 2024 17:03
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant