Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up remaining Punica C information #7027

Merged
merged 4 commits into from
Aug 4, 2024

Conversation

jeejeelee
Copy link
Contributor

#5036 has been merged. Cleaning up the remaining Punica C information.

@mgoin I see that most of these formatting-related files were contributed by you. Could you please take a look at this PR? Thanks~

Copy link

github-actions bot commented Aug 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable to me. Let me take a look myself in the codebase

vllm/config.py Outdated Show resolved Hide resolved
@jeejeelee jeejeelee requested a review from mgoin August 1, 2024 14:20
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 1, 2024
@simon-mo
Copy link
Collaborator

simon-mo commented Aug 1, 2024

I recently comment out the LoRA test to save CI cost. Please run those locally and report back. 🙇‍♂️

@simon-mo
Copy link
Collaborator

simon-mo commented Aug 1, 2024

You can also uncomment them in .buildkite/test-pipeline.yaml and run it in CI

@jeejeelee
Copy link
Contributor Author

@simon-mo I will considering optimizing the LoRA-related unit tests . Additionally, regarding this PR, what test content should I provide feedback on?

@simon-mo
Copy link
Collaborator

simon-mo commented Aug 1, 2024

# - label: LoRA Test %N
# #mirror_hardwares: [amd]
# command: pytest -v -s lora --shard-id=$$BUILDKITE_PARALLEL_JOB --num-shards=$$BUILDKITE_PARALLEL_JOB_COUNT --ignore=lora/test_long_context.py
# parallelism: 4
# - label: LoRA Long Context (Distributed)
# #mirror_hardwares: [amd]
# num_gpus: 4
# # This test runs llama 13B, so it is required to run on 4 GPUs.
# commands:
# # FIXIT: find out which code initialize cuda before running the test
# # before the fix, we need to use spawn to test it
# - export VLLM_WORKER_MULTIPROC_METHOD=spawn
# - pytest -v -s -x lora/test_long_context.py

For this PR to merge, please uncomment these and let it pass in CI first. We are working on optimizing the steps overall. Optimizing the LoRA test is definitely welcomed!

@jeejeelee
Copy link
Contributor Author

@simon-mo The LoRA tests have all passed. It seems that a force merge may be necessary. Furthermore, I've noticed that the test for each LoRA slice takes approximately 20 minutes. If we were to optimize the LoRA testing process, should we focus on reducing this time consumption or on improving the resource efficiency within the LoRA tests?

@simon-mo
Copy link
Collaborator

simon-mo commented Aug 2, 2024

Great. Can you comment it out for now so it doesn't trigger every commit. And we can force merge

@jeejeelee
Copy link
Contributor Author

jeejeelee commented Aug 2, 2024

Great. Can you comment it out for now so it doesn't trigger every commit. And we can force merge

Done.

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this PR? @jeejeelee @simon-mo

@jeejeelee
Copy link
Contributor Author

jeejeelee commented Aug 4, 2024

LGTM! Let's merge this PR? @jeejeelee @simon-mo

Agreed, I think this PR's task is complete, and all related tests have passed

@WoosukKwon WoosukKwon merged commit f80ab35 into vllm-project:main Aug 4, 2024
64 of 66 checks passed
@jeejeelee jeejeelee deleted the optimize-punica branch August 4, 2024 23:33
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants