Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Frontend] Factor out code for running uvicorn" #7012

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

simon-mo
Copy link
Collaborator

Reverts #6828

@DarkLight1337, we need to revert this and reapply this later to accelerate #6797 to be landed this week. Sorry about the back and forth.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 31, 2024
@robertgshaw2-neuralmagic
Copy link
Collaborator

looks like you need to rerun mypi

@simon-mo
Copy link
Collaborator Author

i'm actually confused why this failed.

@joerunde
Copy link
Contributor

joerunde commented Jul 31, 2024

I'm guessing that vllm/server was explicitly added to the list of things for mypy to check with a later commit

(It's currently in pyproject.toml)

@simon-mo simon-mo disabled auto-merge July 31, 2024 23:34
@simon-mo simon-mo merged commit 7eb0cb4 into main Jul 31, 2024
18 of 22 checks passed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
…#7012)

Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants