Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Speculative decoding] Add serving benchmark for llama3 70b + speculative decoding #6964

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[Speculative decoding] Add serving benchmark for llama3 70b + speculative decoding #6964

merged 2 commits into from
Jul 31, 2024

Conversation

cadedaniel
Copy link
Collaborator

  • Use turboderp/Qwama-0.5B-Instruct open model with QPS=2

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@cadedaniel cadedaniel marked this pull request as ready for review July 30, 2024 23:20
comaniac
comaniac approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cadedaniel cadedaniel requested a review from simon-mo July 30, 2024 23:23
@cadedaniel cadedaniel enabled auto-merge (squash) July 30, 2024 23:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2024
@cadedaniel cadedaniel merged commit c32ab8b into vllm-project:main Jul 31, 2024
73 of 74 checks passed
@dtrifiro dtrifiro mentioned this pull request Aug 5, 2024
Closed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@cadedaniel @kylesayrs
[Speculative decoding] Add serving benchmark for llama3 70b + specula…
354f34f 
…tive decoding (vllm-project#6964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees
No one assigned
Labels
perf-benchmarks ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cadedaniel @comaniac @rkooo567 @simon-mo