Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Illegal memory access, FP8 Llama 3.1 405b #6852

Merged

Conversation

LucasWilkinson
Copy link
Contributor

Co-authored-by: Tyler Michael Smith tyler@neuralmagic.com

Should resolve: #6767, #6689 (comment) etc.

Currently the Sm90ColOrScalarBroadcast could read off the end of the scales buffer when the batch size is not a multiple of gemm tile size. Added a predicate tensor and used copy_if to prevent this.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Co-authored-by: Tyler Michael Smith <tyler@neuralmagic.com>
Co-authored-by: tlrmchlsmth <tyler@neuralmagic.com>
@LucasWilkinson
Copy link
Contributor Author

LucasWilkinson commented Jul 26, 2024

Whoever merges this can you please add Tyler Michael Smith (tlrmchlsmth) tyler@neuralmagic.com as a co-author? Thanks!

@LucasWilkinson
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 26, 2024
@comaniac
Copy link
Collaborator

Thanks for the fix! Does this problem reproducible on your end now? If so can we add a unit test? It not then I'm good with CI green.

Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort!!

@LucasWilkinson
Copy link
Contributor Author

LucasWilkinson commented Jul 27, 2024

@comaniac

Does this problem reproducible on your end now?

Unfortunately only when we run Llama 405b server on 8xH100 and hit it with a bunch of requests (granted fairly consistently), but not something I think we can get up and running on the CI (although I'm not that spun up on it).

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Possible data race when running Llama 405b fp8
3 participants