Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][distributed] add message queue for cross-node broadcast #5755

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

youkaichao
Copy link
Member

after we move all the input to CPU, this will help move the driver process outside of the tp 0 worker.

TODO: add multi-node test.

@cadedaniel
Copy link
Collaborator

I'm supportive of this, although I think we should ensure cross-node operations API are compatible with Ray. otherwise we will have to implement a long tail of features to get fault tolerance / handle esoteric TCP errors. 🤮

@youkaichao
Copy link
Member Author

cross-node operations API are compatible with Ray

what does this mean?

@cadedaniel
Copy link
Collaborator

if users want fault tolerance, it should be easy to use Ray for that. we could implement it ourselves if we want so people don't have to use Ray, but it's a lot of work

@youkaichao
Copy link
Member Author

turns out shm broadcast is more efficient in single node:

shm broadcast

Throughput: 39.08 requests/s, 20006.60 tokens/s

pyzmq broadcast:

Throughput: 37.61 requests/s, 19256.93 tokens/s

so we should use shm broadcast inside single node, and use pyzmq for cross-node oly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants