Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Simplify code and fix type annotations in conftest.py #5118

Merged
merged 2 commits into from
Jun 2, 2024
Merged

[Misc] Simplify code and fix type annotations in conftest.py #5118

merged 2 commits into from
Jun 2, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented May 30, 2024 •
edited
Loading

As in title

@rkooo567 after this is merged, I'll edit #5017 to enable type checking under tests/ directory.

This was referenced May 30, 2024
Merged
Merged
@DarkLight1337
Copy link
Member Author

@rkooo567 if you're free, can you review this PR first? Otherwise the original PR which this is based on (#4197) may get merged first xD

ywang96
ywang96 approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix

@ywang96 ywang96 merged commit dfbe60d into vllm-project:main Jun 2, 2024
64 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-conftest-types branch June 3, 2024 01:19
blinkbear pushed a commit to blinkbear/vllm that referenced this pull request Jun 3, 2024
@DarkLight1337 @blinkbear
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
cf6e100 
…project#5118)
blinkbear pushed a commit to blinkbear/vllm that referenced this pull request Jun 6, 2024
@DarkLight1337 @blinkbear
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
a6cafb1 
…project#5118)
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 11, 2024
@DarkLight1337 @robertgshaw2-redhat
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
5008643 
…project#5118)
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
@DarkLight1337 @joerunde
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
a53e398 
…project#5118)
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
@DarkLight1337
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
56750f6 
…project#5118)
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
@DarkLight1337
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
0b981be 
…project#5118)
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@DarkLight1337
[Misc] Simplify code and fix type annotations in conftest.py (vllm-…
e1f269e 
…project#5118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @ywang96 @rkooo567