Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Codespell ignore build/ directory #4945

Merged
merged 2 commits into from
May 21, 2024
Merged

[CI/Build] Codespell ignore build/ directory #4945

merged 2 commits into from
May 21, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented May 21, 2024

Adds the build/ directory to the ignore list of codespell. This directory is present after building binaries when installing from source.

Before this change, if you run ./format.sh --all we will fail during the codespell check and report many issues like:

./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:9967: finitel ==> finite
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27889: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27891: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27891: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27929: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27931: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27942: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27944: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27944: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27982: ans ==> and
./build/temp.linux-x86_64-3.10/CMakeFiles/3.29.2/CompilerIdCUDA/tmp/CMakeCUDACompilerId.cpp4.ii:27984: ans ==> and
...

@simon-mo simon-mo merged commit 757b62c into vllm-project:main May 21, 2024
56 of 61 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request May 31, 2024
@mgoin @dtrifiro
[CI/Build] Codespell ignore build/ directory (vllm-project#4945)
7a89ffb
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 8, 2024
@mgoin @robertgshaw2-redhat
[CI/Build] Codespell ignore build/ directory (vllm-project#4945)
58a235b
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
@mgoin @joerunde
[CI/Build] Codespell ignore build/ directory (vllm-project#4945)
3d9eefc
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jul 14, 2024
@mgoin @robertgshaw2-redhat
[CI/Build] Codespell ignore build/ directory (vllm-project#4945)
f270b9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @rkooo567 @simon-mo