Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hipFuncSetAttribute API not found issue #3477

Closed
wants to merge 1 commit into from
Closed

fix hipFuncSetAttribute API not found issue #3477

wants to merge 1 commit into from

Conversation

hliuca
Copy link
Contributor

@hliuca hliuca commented Mar 18, 2024

Without the header, hipFuncSetAttribute won't be able to find, which causes compilation errors.

@WoosukKwon
Copy link
Collaborator

Hi @hliuca Thanks for submitting the PR! While the hipFuncSetAttribute function is actually defined in hip_runtime_api.h, we haven't met the compilation error before. How did you get the compile error?

@hliuca
Copy link
Contributor Author

hliuca commented Mar 18, 2024

Hi @hliuca Thanks for submitting the PR! While the hipFuncSetAttribute function is actually defined in hip_runtime_api.h, we haven't met the compilation error before. How did you get the compile error?

I am using an internal version, which has a few compilation errors. Let me close this PR and send another one... not fixed completed for now...

@hliuca hliuca closed this Mar 18, 2024
@hliuca
Copy link
Contributor Author

hliuca commented Mar 18, 2024

This actually has been fixed in #3470 four hours ago. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hliuca @WoosukKwon