-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PREFIX CACHING FOLLOW UP] A bunch of fixes to block allocator performance when automatic prefix caching is disabled #3357
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2d2f5bb
Auto prefix performace fixes
ElizaWszola 9468ce8
Small change to no-prefix-caching hashing
ElizaWszola 83cd6ed
Pre-allocate token block list in no-cache scenario
ElizaWszola 4dd06e5
Refactor block manager
ElizaWszola 20b7db8
Clean up evictor, fix
ElizaWszola 690cc5e
Sage's feedback
ElizaWszola 6e50143
Merge branch 'upstream-main' into auto-prefix-perf
ElizaWszola 723e56b
format evictor
ElizaWszola fc9aebb
Fix tests
ElizaWszola c2f74ef
Update vllm/core/block_manager.py
ElizaWszola 17ffc2d
Update vllm/core/block_manager.py
ElizaWszola c383bac
Update vllm/core/block_manager.py
ElizaWszola eaa1fb3
Feedback, one more small modification
ElizaWszola 29f9414
Merge branch 'upstream-main' into auto-prefix-perf
ElizaWszola 65b8213
Update vllm/core/block_manager.py
ElizaWszola 1fc91bb
Update vllm/core/block_manager.py
ElizaWszola e39ae06
Update vllm/core/block_manager.py
ElizaWszola af1285f
Update vllm/core/block_manager.py
ElizaWszola 6c96014
format, disallow sliding window with prefix caching
ElizaWszola c4b69ab
Merge branch 'upstream-main' into auto-prefix-perf
ElizaWszola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does prefix caching work with sliding window now? Should we explicitly check somewhere that if we enable caching, sliding window should not be enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefix caching functionality is simply not used when we have sliding windows. We have specific checks for that in different places in the code. Putting it in a more central place sounds like a better idea though, and less confusing.