-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoRA support for Gemma #3050
Conversation
Looks good, can we extend the test? |
@Yard1 Added. PTAL! |
@Yard1 The PR continues to fail in |
Hmm running the entire thing as a new process should help with cleanup. Or maybe try |
@Yard1 Adding |
Let's merge the PR and optimize the testing time later. I thin this is ok since the lora test is not required for most PRs and the kernel test (which also uses |
Gemma "vocab_size" is 256000, Will the following restrictions have any impact? Should they be removed?
|
We are not supporting lm_head deltas for gemma |
Thank you for your reply @Yard1
Vocal_size verification will only be performed when lm_head is also processed by lora, but please take a look at this question. #3000 |
Closes #3044