[Minor] Remove unused config file #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
Feb 26, 2024
WoosukKwon
reviewed
Feb 26, 2024
Comment on lines
+65
to
+66
| # this model must need this dependency | ||
| from hf_olmo import OLMoConfig |
There was a problem hiding this comment.
What does this mean? Why is hf_olmo required?
There was a problem hiding this comment.
OLMo model use this dependency in the configuration file https://huggingface.co/allenai/OLMo-1B/blob/main/configuration_olmo.py. And this will cause error when loading config.json file. https://buildkite.com/vllm/ci/builds/1707#018de7af-2b65-4c56-bbdc-f9db454e2cc5 So we can safely use this in this model.
There was a problem hiding this comment.
Got it. Thanks for the clarification!
aliencaocao
added a commit
to aliencaocao/vllm
that referenced
this pull request
Feb 29, 2024
This reverts commit d9f726c.
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove unused config file with
transformers.PretrainedConfiginstead.This also a sub PR of #2637.