Include tokens from prompt phase in counter_generation_tokens
#2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Count generation tokens during prompt phase - Add a simple unit test to test the metric
|
@NikolaBorisov @rib-2 Could you please review my PR? |
|
Just so I am clear, the need for this comes from the fact that |
correct. |
NikolaBorisov
approved these changes
Feb 13, 2024
|
@simon-mo This is safe to merge. |
|
@simon-mo Can we merge this. I reviewed it. It is safe and good |
simon-mo
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
counter_generation_tokensmetric was missing tokens generated during the prompt phase, only counting those from the autoregressive generation phase. This PR addresses that by incorporating tokens from both phases into the counter. Also, I've added a simple unit test to verify the counter.