Support logprobs for chat completion api #2292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WoosukKwon @zhuohan123 Could you please have a look at this PR? |
LiuXiaoxuanPKU
requested changes
Jan 17, 2024
| @@ -61,6 +61,7 @@ class ChatCompletionRequest(BaseModel): | |||
| max_tokens: Optional[int] = None | |||
| stop: Optional[Union[str, List[str]]] = Field(default_factory=list) | |||
| stream: Optional[bool] = False | |||
| logprobs: Optional[int] = None | |||
There was a problem hiding this comment.
Could you change the type to bool, which aligns with openAI spec. Also I think in the current codebase, it uses it as bool as well. Please correct me if I'm wrong.
Could you change the type definition of logprobs in CompletionRequest as well? thanks.
| role = get_role() | ||
| for output in final_res.outputs: | ||
| if request.logprobs is not None: |
There was a problem hiding this comment.
if request.logprobs is False(or 0), it will still trigger this branch. Maybe a better way:
if request.logprobs:
# do things
else:
# do things
Please also update the same issue in other places.
|
Close this PR as this feature has been supported in #2918. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://platform.openai.com/docs/api-reference/chat/create#chat-create-logprobs