-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quickstart guide #148
Add quickstart guide #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left minor comments
$ python -m vllm.entrypoints.openai.api_server \ | ||
$ --model facebook/opt-125m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make it a single line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me! Thanks!
Summary: Copy benchmark results to EFS Tag-along fixes : fix `if` statements so all `github-action-benchmark` jobs execute. Test: Manual testing : - A10g x 4 Job : https://github.com/neuralmagic/nm-vllm/actions/runs/8458516524 --------- Co-authored-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
…herry-pick-145-to-release [release] Start by updating the image
Close #106.