Write README and front page of doc #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
commented
Jun 14, 2023
WoosukKwon
commented
Jun 14, 2023
WoosukKwon
commented
Jun 14, 2023
WoosukKwon
commented
Jun 14, 2023
WoosukKwon
commented
Jun 14, 2023
|
@zhuohan123 PTAL. |
zhuohan123
approved these changes
Jun 18, 2023
| ```bash | ||
| python test_cli_client.py | ||
| ``` | ||
| - State-of-the-art performance in serving throughput |
There was a problem hiding this comment.
Suggested change
| - State-of-the-art performance in serving throughput | |
| - State-of-the-art serving throughput |
README.md
Outdated
| python test_cli_client.py | ||
| ``` | ||
| - State-of-the-art performance in serving throughput | ||
| - Efficient management of cached attention keys and values with **PagedAttention** |
There was a problem hiding this comment.
Suggested change
| - Efficient management of cached attention keys and values with **PagedAttention** | |
| - Efficient management of cached attention keys and values memory with **PagedAttention** |
There was a problem hiding this comment.
I think "memory" here is redundant and a bit confusing as we already said they are "cached".
There was a problem hiding this comment.
Fixed to Efficient management of attention key and value memory with **PagedAttention**
docs/source/index.rst
Outdated
| - Efficient support for various decoding algorithms such as parallel sampling and beam search | ||
| - Tensor parallelism support for multi-GPU inference | ||
| - Streaming outputs | ||
| - OpenAI-compatible API |
There was a problem hiding this comment.
Ditto on comments in README.
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
Xaenalt
pushed a commit
to Xaenalt/vllm
that referenced
this pull request
Aug 15, 2024
* Log more HPU memory metrics during vLLM startup * Overhaul memory management in HPUGraph capture * fix percentage in decode buckets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124