Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][BugFix] Clean up rejection sampler & Fix warning msg #13362

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Feb 16, 2025

This PR fixes a few issues in the rejection sampler:

  1. It prints the warning/logging message for every forward call
  2. It does not check the VLLM_USE_FLASHINFER_SAMPLER env variable, which allows users to turn off flashinfer.

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 16, 2025
@WoosukKwon WoosukKwon changed the title [V1] Clean up rejection sampler & Fix warning msg [V1][BugFix] Clean up rejection sampler & Fix warning msg Feb 16, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 16, 2025
@WoosukKwon WoosukKwon merged commit 69e1d23 into main Feb 16, 2025
58 of 60 checks passed
@WoosukKwon WoosukKwon deleted the v1-rejection-sampler branch February 16, 2025 20:25
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
…ct#13362)

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant