[Core] choice-based structured output with xgrammar #12632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Russell Bryant <rbryant@redhat.com>
This commit adds support for using xgrammar with a set of choices. This can be converted to an EBNF grammar pretty easily, which xgrammar can work from. This drops a case where we were falling back to outlines. Part of issue vllm-project#12131 Signed-off-by: Russell Bryant <rbryant@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
5 tasks
mgoin
added
structured-output
ready
mgoin
approved these changes
Jan 31, 2025
| tokenizer_hash=tokenizer_hash, | ||
| max_threads=max_threads, | ||
| tokenizer_data=tokenizer_data, | ||
| ) | ||
| else: | ||
| raise ValueError( | ||
| "Currently only support JSON and EBNF grammar mode for xgrammar" |
njhill
reviewed
Feb 1, 2025
Co-authored-by: Nick Hill <nhill@redhat.com> Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
force-pushed
the
xgrammar-update-0.1.11
branch
from
960b475 to
91e0b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #12131
commit beba609
Author: Russell Bryant rbryant@redhat.com
Date: Thu Jan 30 10:50:43 2025 -0500
commit 4b694af
Author: Russell Bryant rbryant@redhat.com
Date: Thu Jan 30 12:38:25 2025 -0500