Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livez and readyz endpoints #1244

Closed
wants to merge 3 commits into from

Conversation

petrosbaltzis
Copy link

Update api_server to include livez and readyz endpoints. These endpoints are helpful for Kubernetes deployment: https://kubernetes.io/docs/reference/using-api/health-checks/

@zhuohan123
Copy link
Member

Thank you for your contribution! Our goal of api_server.py is to provide a minimal example of an API server. Adding these endpoints will add unnecessary complexity for api_server.py. For your use case, you can make a copy of api_server.py and modify the server for your needs accordingly.

@allenhaozi
Copy link
Contributor

Thank you for your contribution! Our goal of api_server.py is to provide a minimal example of an API server. Adding these endpoints will add unnecessary complexity for api_server.py. For your use case, you can make a copy of api_server.py and modify the server for your needs accordingly.

@zhuohan123 I strongly agree to keep api_server.py as simple as possible

However, almost all private cloud platforms are deployed by kubernetes. If a healthy check function can be provided, most users will not need to maintain an api_server.py independently, which will bring great convenience to vllm users. Because maintaining the branch alone is a very expensive thing to do

If possible, I hope you can reconsider this function, thank you

cc @avnishn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants