[Bugfix] Path join when building local path for S3 clone #12353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
1 task
omer-dayan
force-pushed
the
omer/bugfix-s3-path-join
branch
from
d841785 to
871088e
Compare
DarkLight1337
changed the title
github-actions
bot
added
the
ready
|
Please fix the pre-commit error. |
Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
omer-dayan
force-pushed
the
omer/bugfix-s3-path-join
branch
from
871088e to
557071d
Compare
LucasWilkinson
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jan 24, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
1 task
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 27, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 27, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
tjtanaa
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Jan 28, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Jan 30, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai>
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Feb 2, 2025
…t#12353) Signed-off-by: Omer Dayan (SW-GPU) <omer@run.ai> Signed-off-by: Isotr0py <2037008807@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As arsed in issue #12311,
When running vLLM with S3 path, it clones the meta files locally.
Current state has a bug when building the destination path for every file:
When the S3 path ends with "/" it does not clone the files, due to bug in the building path algorithm.
The solution is to use
os.path.joinA workaround for now is to have the path without "/" at the end
FIX #12311