Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc][V1] Fix type in v1 prefix caching #11151

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[Misc][V1] Fix type in v1 prefix caching #11151

merged 1 commit into from
Dec 13, 2024

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Dec 12, 2024 •
edited by github-actions bot
Loading

Fix the type error reported by #11105

cc @WoosukKwon @markmc

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

WoosukKwon
WoosukKwon approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@comaniac comaniac enabled auto-merge (squash) December 12, 2024 23:15
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 12, 2024
@comaniac
foix
2e1ab7e 
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
@comaniac comaniac merged commit 78ed8f5 into vllm-project:main Dec 13, 2024
50 checks passed
@comaniac comaniac mentioned this pull request Dec 13, 2024
Merged
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@comaniac
[Misc][V1] Fix type in v1 prefix caching (vllm-project#11151)
1d07ac8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic robertgshaw2-neuralmagic is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comaniac @WoosukKwon