Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Consolidate ViTs attention implementation without mask #10893

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 4, 2024

  • This PR adds a MultiHeadAttention layer to consolidate existing duplicate attention forward implementation in ViTs.
  • ViTs that use attention mask are not modified: Qwen2-VL, Pixtral, Mllama.

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Copy link

github-actions bot commented Dec 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py changed the title [Model] Consolidate attention implementation without mask used in ViTs [Model] Consolidate ViTs attention implementation without mask Dec 4, 2024
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2024
@DarkLight1337
Copy link
Member

Unblocked multi-modal tests to see if all of those models still have the correct output.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new errors are introduced by this PR (compared to this nightly build), so it should be fine.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 4, 2024 12:30
@DarkLight1337
Copy link
Member

DarkLight1337 commented Dec 4, 2024

Would be nice if you could fix the InternVL tests here as well though! I've already asked for access to MiniCPMV to resolve the gated repo error.

Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Dec 4, 2024

The failing internvl tests should also be fixed in new commit now.

Signed-off-by: Isotr0py <2037008807@qq.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 4, 2024 16:58
@DarkLight1337 DarkLight1337 merged commit 10398b4 into vllm-project:main Dec 4, 2024
56 checks passed
@Isotr0py Isotr0py deleted the refactor-vit-attn branch December 5, 2024 02:04
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants