-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Consolidate ViTs attention implementation without mask #10893
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Unblocked multi-modal tests to see if all of those models still have the correct output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new errors are introduced by this PR (compared to this nightly build), so it should be fine.
Would be nice if you could fix the InternVL tests here as well though! I've already asked for access to MiniCPMV to resolve the gated repo error. |
Signed-off-by: Isotr0py <2037008807@qq.com>
The failing internvl tests should also be fixed in new commit now. |
Signed-off-by: Isotr0py <2037008807@qq.com>
…project#10893) Signed-off-by: Isotr0py <2037008807@qq.com>
MultiHeadAttention
layer to consolidate existing duplicate attention forward implementation in ViTs.