-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix BNB loader target_modules #10720
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
@mgoin Sorry for bother you, if you have bandwidth ,please look at this PR, thanks |
Apologies for missing, this looks reasonable to me if the CI is green! |
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Motivation
When addressing the following TODO, I found a misconception regarding the use of
target_modules
. The issue arises becausetarget_modules
specifies which layers should have LoRA adapters added, rather than which layers should be quantized.vllm/vllm/model_executor/model_loader/loader.py
Line 714 in 15cc2a9
Reproduce Code