Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix slow tests #10698

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[ci] fix slow tests #10698

merged 3 commits into from
Nov 27, 2024

Conversation

youkaichao
Copy link
Member

the ci machine might have less powerful cpus, and i observed that in https://buildkite.com/vllm/ci/builds/10175#01936aa9-a7a8-4aff-8ced-d4cfca8223a1 , these tests need to run for half an hour. (need to download the full log to see the details)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao merged commit 308cc5e into vllm-project:main Nov 27, 2024
22 checks passed
@youkaichao youkaichao deleted the fix_tests branch November 27, 2024 17:26
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants