Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Fix Baichuan BNB online quantization #10572

Merged
merged 1 commit into from
Nov 23, 2024
Merged

[Model] Fix Baichuan BNB online quantization #10572

merged 1 commit into from
Nov 23, 2024

Conversation

CNTRYROA
Copy link
Contributor

@CNTRYROA CNTRYROA commented Nov 22, 2024 •
edited
Loading

fix baichuan bnb quantization on the fly

@CNTRYROA
Fix Baichuan BNB online quantization
3a58c1a 
Signed-off-by: Chen Wu <cntryroa@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@CNTRYROA CNTRYROA changed the title Fix Baichuan BNB online quantization [Bugfix] Fix Baichuan BNB online quantization Nov 22, 2024
@CNTRYROA CNTRYROA changed the title [Bugfix] Fix Baichuan BNB online quantization [Model] Fix Baichuan BNB online quantization Nov 22, 2024
Isotr0py
Isotr0py approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Tested on baichuan-inc/Baichuan2-7B-Base with tp=1 and tp=2)

@Isotr0py
Copy link
Collaborator

You can merge from main branch to re-run the failing CI.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 22, 2024
@mgoin mgoin enabled auto-merge (squash) November 22, 2024 21:57
@DarkLight1337
Copy link
Member

#10581 should fix the CI failure, please merge from main again.

@youkaichao youkaichao disabled auto-merge November 23, 2024 05:13
@youkaichao youkaichao merged commit cfea9c0 into vllm-project:main Nov 23, 2024
63 of 68 checks passed
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@CNTRYROA @mfournioux
[Model] Fix Baichuan BNB online quantization (vllm-project#10572)
2de7c33 
Signed-off-by: Chen Wu <cntryroa@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@CNTRYROA
[Model] Fix Baichuan BNB online quantization (vllm-project#10572)
7d5171c 
Signed-off-by: Chen Wu <cntryroa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CNTRYROA @Isotr0py @DarkLight1337 @mgoin @youkaichao