[Bugfix] Marlin 2:4 temp fix for large M dim (>256) #10464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasWilkinson
requested review from
tlrmchlsmth and
WoosukKwon
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
LucasWilkinson
force-pushed
the
lwilkinson/marlin_24_fix
branch
from
8cf8329 to
c12f6eb
Compare
tlrmchlsmth
approved these changes
Nov 19, 2024
mgoin
approved these changes
Nov 19, 2024
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
danieldk
added a commit
to huggingface/text-generation-inference
that referenced
this pull request
Nov 22, 2024
This fixes a bug in 2:4 Marlin: vllm-project/vllm#10464
5 tasks
danieldk
added a commit
to huggingface/text-generation-inference
that referenced
this pull request
Nov 22, 2024
This fixes a bug in 2:4 Marlin: vllm-project/vllm#10464
OlivierDehaene
pushed a commit
to huggingface/text-generation-inference
that referenced
this pull request
Nov 22, 2024
This fixes a bug in 2:4 Marlin: vllm-project/vllm#10464
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot fix for Marlin 2:4 returning incorrect results for large M dimensions