-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Remove float32 choice from --lora-dtype #10348
Conversation
Signed-off-by: Xin Yang <xyang19@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this confusing bit!
Signed-off-by: Xin Yang <xyang19@gmail.com>
Signed-off-by: Xin Yang <xyang19@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Signed-off-by: Xin Yang <xyang19@gmail.com> Signed-off-by: rickyx <rickyx@anyscale.com>
Signed-off-by: Xin Yang <xyang19@gmail.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Xin Yang <xyang19@gmail.com>
Remove float32 choice from --lora-dtype because float32 is not really supported.
I ran the command below following https://github.com/vllm-project/vllm/blob/main/docs/source/models/lora.rst:
Got the error below because of AssertionError: https://github.com/vllm-project/vllm/blob/main/vllm/lora/ops/sgmv_expand.py#L133-L136