Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Bugfix] Propagate V1 LLMEngine properly #10127

Closed
wants to merge 1 commit into from

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Nov 7, 2024

#9888 makes V1 LLMEngine import lazily, but failed to pass the right engine to the constructor, resulting in crashing when launching the engine.

We should really make some basic tests for v1 ASAP...

cc @joerunde @WoosukKwon @youkaichao

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link

github-actions bot commented Nov 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac changed the title [V1] Fix bug introduced by #9888 [V1][Bugfix] Propagate V1 LLMEngine properly Nov 7, 2024
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 7, 2024
@njhill
Copy link
Member

njhill commented Nov 7, 2024

@comaniac I'm just checking whether this makes sense given that we won't use MQLLMEngine with V1.

@njhill
Copy link
Member

njhill commented Nov 7, 2024

Yes this won't be needed once we merge #9826 (hopefully imminently), which reverts the use of v1 engine in mutliprocessing/engine.py.

@comaniac
Copy link
Collaborator Author

comaniac commented Nov 7, 2024

Ok make sense. Than we could close this one once #9825 is merged.

@joerunde
Copy link
Contributor

joerunde commented Nov 8, 2024

Ah, good catch @comaniac!

I will start enabling more tests with v1, but won't do any of the engine/multiprocessing ones since this won't be used with v1

@DarkLight1337
Copy link
Member

Closing as #9826 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants