Skip to content

Commit

Permalink
Skip xfail tests on ROCm to conserve CI resources
Browse files Browse the repository at this point in the history
  • Loading branch information
mawong-amd committed Jun 25, 2024
1 parent 016a553 commit 40c33ec
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
3 changes: 3 additions & 0 deletions tests/models/test_llava_next.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from transformers import AutoTokenizer

from vllm.config import VisionLanguageConfig
from vllm.utils import is_hip

from ..conftest import IMAGE_FILES

Expand Down Expand Up @@ -72,6 +73,8 @@ def vllm_to_hf_output(vllm_output: Tuple[List[int], str],
return hf_input_ids, hf_output_str


@pytest.mark.skipif(
is_hip(), reason="ROCm is skipping xfail tests to conserve CI resources")
@pytest.mark.xfail(
reason="Inconsistent image processor being used due to lack "
"of support for dynamic image token replacement")
Expand Down
4 changes: 3 additions & 1 deletion tests/models/test_phi3v.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from transformers import AutoTokenizer

from vllm.config import VisionLanguageConfig
from vllm.utils import is_cpu
from vllm.utils import is_cpu, is_hip

from ..conftest import IMAGE_FILES

Expand Down Expand Up @@ -76,6 +76,8 @@ def vllm_to_hf_output(vllm_output: Tuple[List[int], str],
# TODO: Add test for `tensor_parallel_size` [ref: PR #3883]
# Since we use _attn_implementation="eager" for hf_runner, here is
# numeric difference for longer context and test can't pass
@pytest.mark.skipif(
is_hip(), reason="ROCm is skipping xfail tests to conserve CI resources")
@pytest.mark.xfail(
reason="Inconsistent image processor being used due to lack "
"of support for dynamic image token replacement")
Expand Down
5 changes: 5 additions & 0 deletions tests/multimodal/test_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from vllm.config import ModelConfig, VisionLanguageConfig
from vllm.multimodal import MULTIMODAL_REGISTRY
from vllm.multimodal.image import ImagePixelData
from vllm.utils import is_hip

from ..conftest import _STR_DTYPE_TO_TORCH_DTYPE

Expand Down Expand Up @@ -55,6 +56,8 @@ def test_clip_image_processor(hf_images, dtype):
assert np.allclose(hf_arr, vllm_arr), f"Failed for key={key}"


@pytest.mark.skipif(
is_hip(), reason="ROCm is skipping xfail tests to conserve CI resources")
@pytest.mark.xfail(
reason="Inconsistent image processor being used due to lack "
"of support for dynamic image token replacement")
Expand Down Expand Up @@ -104,6 +107,8 @@ def test_llava_next_image_processor(hf_images, dtype):
assert np.allclose(hf_arr, vllm_arr), f"Failed for key={key}"


@pytest.mark.skipif(
is_hip(), reason="ROCm is skipping xfail tests to conserve CI resources")
@pytest.mark.xfail(
reason="Example image pixels were not processed using HuggingFace")
@pytest.mark.parametrize("dtype", ["float"])
Expand Down

0 comments on commit 40c33ec

Please sign in to comment.