Open turfs handle space below #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorDinamit
added
the
🔨1 Tweak
|
Considering adding a subtype of space turf for that to handle every single issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Pull Request
An attempt at making open turfs handle space turfs below them a bit better;
We achieve it by just clearing the dynamic lighting from open turfs whenever there's a space turf below.
I am not too knowledgeable on what this could break, but it works and looks good.
Why It's Good For The Game
It always annoyed me when you would be flying in space and not see anything happening right under you.
Did you test it?
Yes.
Authorship
Me.
Changelog
🆑
tweak: Open turfs now handle lighting of space turfs below them.
/:cl: