Adds SolGov shuttle for players to play on #468
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bam40002
force-pushed
the
sol-shuttle
branch
2 times, most recently
from
5c4a9ff to
a58e097
Compare
-Adds a sol shuttle Shuttle things -Fixes airlock -Random names! (Still broken) Varying Variable Troubles -Changed the format to TGM -Almost fixed the Airlock Stupid Quotes -added a " to a thing Mapping Fixes -Fixed some duplicate things on top of eachother. -Removed some atmospherics pipes going into nowhere. Mapping fixed. -This map has issues and I fixed a bit Duplicate Crap -Catwalks on catwalks removed
EgorDinamit
reviewed
Aug 30, 2023
EgorDinamit
reviewed
Aug 30, 2023
|
|
||
| /obj/effect/overmap/visitable/ship/landable/sol_shuttle | ||
| name = "SolGov Cruiser" | ||
| desc = "Sensor array detects a small SolGov Cruiser." |
There was a problem hiding this comment.
Same here, but it could also use a bit more text to describe some details, maybe?
EgorDinamit
reviewed
Aug 30, 2023
maps/away/sol_shuttle/sol_shuttle.dm
Outdated
| vessel_size = SHIP_SIZE_SMALL | ||
|
|
||
| /obj/effect/overmap/visitable/ship/landable/sol_shuttle/New() | ||
| name = "SEV [pick("Quantum", "Enterprise", "Event Horizon", "Notch","Discovery","Vagrant")]" |
There was a problem hiding this comment.
I'd imagine "SEV" doesn't exactly fit there, no? "SEV" stands for "Sol Exploratory Vessel", if I am not mistaken.
There was a problem hiding this comment.
I will change it to SFV meaning Sol Fleet Vessel.
EgorDinamit
reviewed
Aug 30, 2023
| name = "SEV [pick("Quantum", "Enterprise", "Event Horizon", "Notch","Discovery","Vagrant")]" | ||
| for(var/area/sol_shuttle/A) | ||
| A.name = "\improper [name] - [A.name]" | ||
| GLOB.using_map.area_purity_test_exempt_areas += A.type |
There was a problem hiding this comment.
Randomly picking a name? I think so.
EgorDinamit
reviewed
Aug 30, 2023
EgorDinamit
reviewed
Aug 30, 2023
| preset_name = "SEV Quantum" | ||
|
|
||
| /obj/machinery/telecomms/server/map_preset/sol_shuttle | ||
| preset_name = "SEV Quantum" |
There was a problem hiding this comment.
Might want to give it some generic channel name instead? Let alone, ship might not be even called that when it spawns.
There was a problem hiding this comment.
On it! The SEV Quantum was the placeholder name.
-Fixed the shuttle, it works now -Made a few mapping changes -Added placeholder map for the second shuttle -Changed job descriptions a bit
-Added new job the VIP (might need to remove one) -Mapped a bit of the second shuttle -Tweaked the first shuttle a bit -Made it so when undocked the shuttle still has gravity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it add?
Adds a playable SolGov shuttle.
Im planning to make it choose between map files so not every round the shuttle spawns in is the same map and the layout of the shuttle is different. (broken english)
Why is it good for the game?
Could lead to fun interactions with the intrepid.
Authorship
Me (based a bit on egors OBS shuttle with the code)
Changelog
🆑 Bam4000
rscadd - Added offship solgov shuttle role
/:cl: