Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts hard-coded variables to datums in the fishing subsystem + minor fishing skills cleanup #2535

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Gboster-0
Copy link
Collaborator

@Gboster-0 Gboster-0 commented Nov 4, 2024

About The Pull Request

  • Recodes the fishing subsystem to have a list of datums instead of hard-coded variables
  • Fish market now checks for the map before the proc, so admins can easily enable the CF/COL fish markets at their demand (let me test things locally easier dammit!)
  • Fixed a lot of fish bugs

Why It's Good For The Game

Recodes the fishing subsystem to have a list of datums instead of hard-coded variables

  • The shitcode and hardcode is real, cleaned it up a good chunk
  • This does also allow admins to make custom planets, or copies of pre-existing planets

Fish market now checks for the map before the proc, so admins can easily enable the CF/COL fish markets at their demand (let me test things locally easier dammit!)

  • It just better, also i added a QDEL_LIST() before setting a new list there since quite sure those datums were never being cleared

Fixed a lot of fish bugs

  • Bugs bad, the full list in the changelog

Changelog

🆑
code: recoded the fishing subsystem
qol: You can no longer detonate your own god's planet
fix: You can no longer detonate a detonated planet
fix: You can no longer move a detonated planet's phase with "Planet 1" and "Planet 2"
/:cl:

@Gboster-0 Gboster-0 added Code improvement Code is now easier to copy paste. Side content This PR affects side modes. labels Nov 4, 2024
@Gboster-0 Gboster-0 changed the title Back-end fishing rework (nothing player facing) Converts hard-coded variables to datums in the fishing subsystem + minor fishing skills cleanup Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste. Side content This PR affects side modes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant