Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carnival Update #2528

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

EnderMage99
Copy link
Contributor

About The Pull Request

Carnival Updates:

  1. Adds 3 new silk types and gives all silks their masterpiece/elegant variants.
  2. Updates all of the armor recipes to be a lot more equal. So each one takes about the same amount of effort. Also, Now the recipes are more complicated in which silk they use.
  3. Lets the Carnival create Human silk by butchering Lovetown and lets them craft Human Silk, (However it does take a bit of effort.)
  4. Carnival can no longer Bucher dead humans which have a soul.
  5. Makes their spear deal half damage to humans.
  6. Carnival can now spawn in City Fixers
  7. Adds a new book, which lets the carnival create some really powerful endgame armor.
  8. Gives them a "Silk Bag" that is able to hold a large amount of silk without taking up a lot of room.
  9. Silk can only be applied to armor by the Carnival, and only the Carnival can read their weaving books.
  10. It organizes the Carnival crafting recipes which makes their code much cleaner.

Also, This adds the "Meat Bag" for fixers.
This bag can be bought at fixer vending machines and it can hold around 12 different meat slabs at one time.
It should make selling/carrying all of that meat more convenient for fixers.

Why It's Good For The Game

Along with adding a bit more depth to the carnival by encouraging them to combine their silk into better types to make armor, this helps City Fixers with making armor much more accessible there.

This also makes the Carnival much less antagonist towards humans, which should allow them to focus on the selling aspect of them, rather than the hunting humans part.

Changelog

🆑
add: added Shrimple, Crimson and Violet Silk
reworked: reworked all of the recipes for crafting armor to be more equal.
add: the silk/meat bags to CoL/CF
add: the carnival to CF
nerf: the carnival spear deals half damage to humans
add: makes silk stuff exclusive with the carnival
add: the carnival is now able to craft midnight ordeal armor, at a VERY high cost.
nerf: the silkweaver can no longer bucher humans with souls.
/:cl:

@Gboster-0
Copy link
Collaborator

wow, quite a huge balance rework

@Gboster-0 Gboster-0 added Balance Improvements towards balance of the game. Side content This PR affects side modes. Expansion Expands upon a feature labels Nov 2, 2024
@Kitsunemitsu
Copy link
Contributor

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.

I'd like it instead to be attached to the workshop, to give them more to do.

@EnderMage99
Copy link
Contributor Author

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.

I'd like it instead to be attached to the workshop, to give them more to do.

Well, I trying to make them less hostile to players, since they now deal less damage to humans and can’t butcher dead people.

But, I like the idea of adding them to the workshop since there a lot less players in CF.

However, I am also wondering how should I handle the fact that the carnival can go into the backstreets but the workshop can’t? Should I give them the carnival spear or not?

@EnderMage99
Copy link
Contributor Author

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.

I'd like it instead to be attached to the workshop, to give them more to do.

Also, When you say “don't really want to add bloat to more CF roles” do you mean you don’t want me to add more silk types?

@Kitsunemitsu
Copy link
Contributor

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.
I'd like it instead to be attached to the workshop, to give them more to do.

Also, When you say “don't really want to add bloat to more CF roles” do you mean you don’t want me to add more silk types?

Actually It's more that Workshop is already bored as hell by midround; I think that giving them armor crafting (and maybe prosthetics too soon, if there's the space near their workshop) would help them be more occupied into the lategame

@Kitsunemitsu
Copy link
Contributor

However, I am also wondering how should I handle the fact that the carnival can go into the backstreets but the workshop can’t? Should I give them the carnival spear or not?

About them going into the backstreets, first off, they can, and I want to encourage them to, and second off, they can get the bodies shipped straight to them if needed.

Just reskin the carnival spear as a subtype or whatever if needed.

@Tokanova
Copy link

Tokanova commented Nov 2, 2024

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.
I'd like it instead to be attached to the workshop, to give them more to do.

Also, When you say “don't really want to add bloat to more CF roles” do you mean you don’t want me to add more silk types?

Actually It's more that Workshop is already bored as hell by midround; I think that giving them armor crafting (and maybe prosthetics too soon, if there's the space near their workshop) would help them be more occupied into the lategame

Can the workshop not be made 'taller', so it goes further into the backstreets? That'd give more room.

@EnderMage99
Copy link
Contributor Author

I don't really want to add bloat to more CF roles, especially one that's "hostile" by default like Carnivals.
I'd like it instead to be attached to the workshop, to give them more to do.

Also, When you say “don't really want to add bloat to more CF roles” do you mean you don’t want me to add more silk types?

Actually It's more that Workshop is already bored as hell by midround; I think that giving them armor crafting (and maybe prosthetics too soon, if there's the space near their workshop) would help them be more occupied into the lategame

Can the workshop not be made 'taller', so it goes further into the backstreets? That'd give more room.

Sadly, That is where the backstreets load, so it would get overwritten by the backstreets spawner.

EnderMage99 and others added 2 commits November 5, 2024 10:34
Thanks Ghoster-0 for noticing this!

Co-authored-by: Gboster-0 <82319946+Gboster-0@users.noreply.github.com>
Thanks Ghoster-0 for noticing this!

Co-authored-by: Gboster-0 <82319946+Gboster-0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Improvements towards balance of the game. Expansion Expands upon a feature Side content This PR affects side modes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants