Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks how the possession blacklist is handled, Admins can now disable possessing on individual abnormalities. #2461

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Gboster-0
Copy link
Collaborator

About The Pull Request

  • Changes the global forbidden abnormality possession blacklist into a var on every abnormality that gets checked instead
  • Moves some if() checks around into better spots
  • Removes the admin message if someone tries to possess whilst possession is not enabled

Why It's Good For The Game

Changes the global forbidden abnormality possession blacklist into a var on every abnormality that gets checked instead

  • This way, admins can disable any abnormality they are preparing for adminbus and dont want a ghost entering into. Also cleaner

Moves some if() checks around into better spots

  • Please, let me bury the history of me making the code check if possession is enabled in SSlobotomy subsystem EVERY time it checks if a mob is valid to possess, god the inefficiency

Removes the admin message if someone tries to possess whilst possession is not enabled

  • It's not really needed, no harm is being done

Changelog

🆑
admin: you can now disable possession on individual abnormality's by changing their do_not_possess var
/:cl:

@Gboster-0 Gboster-0 added the Code improvement Code is now easier to copy paste. label Oct 5, 2024
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Love it

@Kitsunemitsu Kitsunemitsu merged commit 823f8c3 into vlggms:master Oct 31, 2024
8 checks passed
@Gboster-0 Gboster-0 deleted the possession-override branch October 31, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants