Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v: fix all memleaks to enable memleak detection #23200

Merged
merged 18 commits into from
Dec 20, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 18, 2024

This PR aims to fix all memleak found on sanitize tests for enabling detect_leaks=1

PS: Some sqlite test were fixed because indirect leak was spotted on gcc sanitizer.

Huly®: V_0.6-21637

@felipensp felipensp marked this pull request as ready for review December 18, 2024 14:02
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you 🙇🏻‍♂️.

@spytheman
Copy link
Member

I think we may have to skip the orm tests again for now (the ones that use sqlite) 🤔 .

@felipensp
Copy link
Member Author

I think we may have to skip the orm tests again for now (the ones that use sqlite) 🤔 .

Ok, I'll treat the known cases in the .suppressions file.

@felipensp
Copy link
Member Author

felipensp commented Dec 19, 2024

Some sqlite tests were fixed because indirect leak was spotted on gcc sanitizer.

@spytheman spytheman merged commit b077219 into vlang:master Dec 20, 2024
72 of 73 checks passed
@felipensp felipensp deleted the fix_several_memleaks branch December 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants