Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix codegen for array append on indexexpr #23160

Merged
merged 1 commit into from
Dec 14, 2024
Merged

cgen: fix codegen for array append on indexexpr #23160

merged 1 commit into from
Dec 14, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 14, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review December 14, 2024 12:54
spytheman
spytheman approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 881fabf into vlang:master Dec 14, 2024
72 checks passed
@felipensp felipensp deleted the fix_indexexpr_left_shift branch December 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler error when appending to the z axis of a width and height fixed 3d array
2 participants
@felipensp @spytheman